Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go 1.22 and 1.23 to socket tracer tests. Bump minor go versions #2116

Conversation

ddelnano
Copy link
Member

@ddelnano ddelnano commented Feb 10, 2025

Summary: Add go 1.22 and 1.23 to socket tracer tests. Bump minor go versions

This PR adds Go 1.22 and 1.23 to the socket tracer test suite in anticipation of removing Go 1.16 and 1.17 from our repo once #2108 is merged. The plan is to follow this up with a change that removes Go 1.16 and 1.17 in addition to upgrading a portion of our Go dependencies. The bulk of our dependencies still support Go 1.18, so this will allow us to upgrade to the latest versions.

Relevant Issues: N/A

Type of change: /kind cleanup

Test Plan: Test suite passes

@ddelnano ddelnano force-pushed the ddelnano/add-go-1.22-1.23-bump-minor-go-versions branch 2 times, most recently from 606704a to f1e0a03 Compare February 10, 2025 17:19
@ddelnano ddelnano force-pushed the ddelnano/add-go-1.22-1.23-bump-minor-go-versions branch from a4c9673 to b334f6d Compare February 11, 2025 06:56
@ddelnano ddelnano marked this pull request as ready for review February 11, 2025 14:51
@ddelnano ddelnano requested review from a team as code owners February 11, 2025 14:51
Copy link
Contributor

@oazizi000 oazizi000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In person discussion notes:

Let's think about removing 1.16 and 1.17 everywhere in the code. They are EOL'ed, and have security concerns.

@ddelnano ddelnano merged commit 09ade3b into pixie-io:main Feb 11, 2025
36 checks passed
@ddelnano ddelnano deleted the ddelnano/add-go-1.22-1.23-bump-minor-go-versions branch February 11, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants