Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for lag when opening sidebar using toggle sidebar brick #8295

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

grahamlangford
Copy link
Collaborator

What does this PR do?

Demo

https://www.loom.com/share/d6b96b187b2741d18eab4a9c35e99eb7

Checklist

@grahamlangford grahamlangford marked this pull request as draft April 19, 2024 18:27
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.56%. Comparing base (bc5d406) to head (ef2f2a4).

Files Patch % Lines
src/contentScript/sidebarController.tsx 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8295      +/-   ##
==========================================
+ Coverage   73.55%   73.56%   +0.01%     
==========================================
  Files        1329     1329              
  Lines       40929    40931       +2     
  Branches     7565     7565              
==========================================
+ Hits        30105    30111       +6     
+ Misses      10824    10820       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

When the PR is merged, the first loom link found on this PR will be posted to #sprint-demo on Slack. Do not edit this comment manually.

@grahamlangford grahamlangford merged commit 4f2d3fc into main Apr 19, 2024
22 checks passed
@grahamlangford grahamlangford deleted the fix-sidebar-open-lag branch April 19, 2024 19:19
@grahamlangford grahamlangford added this to the 1.8.13 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants