Skip to content

Commit

Permalink
Remove the --yes from what we suggest to the user
Browse files Browse the repository at this point in the history
  • Loading branch information
mxcl committed Jan 16, 2025
1 parent f2a306b commit 7bdb169
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions installer.sh
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ _install_pre_reqs() {
export DEBIAN_FRONTEND=noninteractive
cmd=$1
shift
$SUDO apt-get $cmd -qq -o=Dpkg::Use-Pty=0 $@
$SUDO apt-get $cmd --yes -qq -o=Dpkg::Use-Pty=0 $@

Check warning on line 57 in installer.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote to prevent globbing and word splitting. Raw Output: ./installer.sh:57:21: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check failure on line 57 in installer.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote array expansions to avoid re-splitting elements. Raw Output: ./installer.sh:57:55: error: Double quote array expansions to avoid re-splitting elements. (ShellCheck.SC2068)
}
else
apt() {
Expand All @@ -78,7 +78,7 @@ _install_pre_reqs() {
fi

if test -f /etc/debian_version; then
apt update --yes
apt update

# minimal but required or networking doesn’t work
# https://packages.debian.org/buster/all/netbase/filelist
Expand All @@ -92,13 +92,13 @@ _install_pre_reqs() {

case $(cat /etc/debian_version) in
jessie/sid|8.*|stretch/sid|9.*)
apt install --yes libc-dev libstdc++-4.8-dev libgcc-4.7-dev $A $B $C;;
apt install libc-dev libstdc++-4.8-dev libgcc-4.7-dev $A $B $C;;
buster/sid|10.*)
apt install --yes libc-dev libstdc++-8-dev libgcc-8-dev $A $B $C;;
apt install libc-dev libstdc++-8-dev libgcc-8-dev $A $B $C;;
bullseye/sid|11.*)
apt install --yes libc-dev libstdc++-10-dev libgcc-9-dev $A $B $C;;
apt install libc-dev libstdc++-10-dev libgcc-9-dev $A $B $C;;
bookworm/sid|12.*|*)
apt install --yes libc-dev libstdc++-11-dev libgcc-11-dev $A $B $C;;
apt install libc-dev libstdc++-11-dev libgcc-11-dev $A $B $C;;
esac
elif test -f /etc/fedora-release; then
$SUDO yum --assumeyes install libatomic
Expand Down

0 comments on commit 7bdb169

Please sign in to comment.