By default, only report progress when stderr is a terminal #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th1000s
commented
Jan 14, 2025
Comment on lines
+752
to
+755
| /// Override progress reporting, by default (=auto) only report when stderr is a terminal. | ||
| /// Possible values: true, false, auto. | ||
| #[arg(long, value_name = "VAL", require_equals = true, | ||
| value_parser(["auto", "true", "false"]), default_value = "auto", |
There was a problem hiding this comment.
I thought about also adding default_missing_value = "true", num_args = 0..=1, so that --progress == --progress=true, but that would make the help text even longer and harder to understand. And a value parser to convert "true" etc. is also possible, but that makes the argparse logic more complex than the simple thing which it toggles.
Can be overridden by --progress=[true/false/auto]. Previous option --quiet hidden, but kept for compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be overridden by
--progress=[true/false/auto]. Previousoption
--quiethidden, but kept for compatibility.Avoids getting mailed or logging a bunch of
[<===> ]lines. Also contains two clippy fix commits for v1.84.