Change submission language #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @jyhein! It looks like the tests are not yet passing, but in any case, please let us know when you're ready for a review of the code. |
jyhein
force-pushed
the
f5502
branch
10 times, most recently
from
f1df687 to
0b31c77
Compare
|
Hey @asmecher, I have PRs ready for review of the code... OJS: #4016 OMP: pkp/omp#1451 |
jyhein
force-pushed
the
f5502
branch
2 times, most recently
from
2b94387 to
88f1b3a
Compare
jyhein
force-pushed
the
f5502
branch
3 times, most recently
from
8fa05cb to
8ebef0c
Compare
jyhein
force-pushed
the
f5502
branch
2 times, most recently
from
cb155bc to
7c504e2
Compare
jyhein
force-pushed
the
f5502
branch
2 times, most recently
from
7025ea5 to
b68eca0
Compare
jyhein
force-pushed
the
f5502
branch
2 times, most recently
from
a144d6d to
98ded9c
Compare
jyhein
force-pushed
the
f5502
branch
3 times, most recently
from
794d289 to
e158316
Compare
jyhein
force-pushed
the
f5502
branch
2 times, most recently
from
896e5b6 to
9d2f696
Compare
ewhanson
reviewed
Aug 7, 2024
ewhanson
reviewed
Aug 7, 2024
bozana
reviewed
Sep 11, 2024
bozana
reviewed
Sep 11, 2024
|
Hi @ewhanson In the new UI, I had made the information indicator, like "Submission Language," regular and the actual information, such as "English," bold. I did this because I thought the information itself was more important for the user. However, I didn’t realize that in previous versions, it was the other way around. So, please feel free to change it back, making "Submission Language" bold and "English" regular. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the submission language after submission
Show the language of the submission in the workflow page and the author dashboard
In the modal window editors can change the language and add/edit required metadata
The submission's metadata can be edited even if the submission's locale is not one of the currently supported submission locales
The language of the submission can not be changed if the status of the publication is published or there are more than one version
A test to check when it is allowed and not to change the language