import Native xml, restrict review stages

[withanage]

Issue

• Native XML Export/Import is not handling internal review round correctly #10606

[bozana]

Hi @withanage,
I think it would be better to implement it in the appropriate filter, i.e. in NatvieXmlSubmissionFilter, in the function handleElement():
The new code is only for submissions, on submission level. You do check it in the function addReviewStage, but I believe it is cleaner and better/easier to read it all in the NativeXmlSubmissionFilter, because a developer would look at the code for submission import there and would not know/have in mind that something is also happening here.
Also, I am not 100% sure, but could it be that $this->processResult could contain multiple submissions? You are considering only one in the function addReviewStage: $submission = $this->processResult[0];.
Thanks a lot!

[withanage]

Thanls a lot @bozana , I changed the implementation according to your suggestion and pushed.

Also, I am not 100% sure, but could it be that $this->processResult could contain multiple submissions? You are considering only one in the function addReviewStage: $submission = $this->processResult[0];.

I think this use-case does not arise, when we handle it in the filter.

[bozana]

Hi @withanage, thanks a lot!
I think one change is still needed: the review round parameter is missing. Else, just cosmetic comments... :-)
Thanks a lot!

[withanage]

@bozana thanks for the review, I updated a revised commit

[bozana]

Hi @withanage, great! All good! Thanks a lot!
Would you maybe like to enable the test it('Imports submissions from XML', function() { in NativeXmlImportExportSubmission.cy.js in a PR for OJS, OMP and OPS, and also add this submodule update, so that we see if the test passes then?