pkp/pkp-lib#10792 update ORCiD branding #10829
Conversation
taslangraham
force-pushed
the
i10792-main
branch
from
fd6e838 to
8a4d04a
Compare
taslangraham
changed the title
taslangraham
force-pushed
the
i10792-main
branch
from
8a4d04a to
efc7e5a
Compare
| @@ -24,8 +24,8 @@ | |||
| <span class="date_start">{translate key="common.fromUntil" from=$mastheadUser['dateStart'] until=""}</span> | |||
| <span class="name"> | |||
| {$mastheadUser['user']->getFullName()|escape} | |||
| {if $mastheadUser['user']->getData('orcid') && $mastheadUser['user']->getData('orcidAccessToken')} | |||
| <span class="orcid"> | |||
| {if $mastheadUser['user']->getData('orcid') && $mastheadUser['user']->getData('orcidAccessToken') && $mastheadUser['user']->hasVerifiedOrcid()} | |||
There was a problem hiding this comment.
I think we should remove the check for the orcidAccessToken as the addition of hasVerifiedOrcid covers this better.
| @@ -30,7 +30,7 @@ | |||
| </span> | |||
| <span class="name"> | |||
| {$mastheadUser['user']->getFullName()|escape} | |||
| {if $mastheadUser['user']->getData('orcid') && $mastheadUser['user']->getData('orcidAccessToken')} | |||
| {if $mastheadUser['user']->getData('orcid') && $mastheadUser['user']->getData('orcidAccessToken') && $mastheadUser['user']->hasVerifiedOrcid()} | |||
There was a problem hiding this comment.
I think we should remove the check for the orcidAccessToken as the addition of hasVerifiedOrcid covers this better.
classes/identity/Identity.php
Outdated
| return null; | ||
| } | ||
|
|
||
| return $this->hasVerifiedOrcid() ? $this->getOrcid() : $this->getOrcid() . ' (' . __('orcid.unauthenticated') . ')'; |
There was a problem hiding this comment.
I don't really have a strong opinion on it, but did you consider having the parenthesis as part of the locale string instead of direct formatting here? I don't know if there would be any circumstances where other languages would have issues with this formatting, but just wanted to throw it out there.
There was a problem hiding this comment.
Don't quite remember why I decided to format it in PHP, but I've found existing strings with parenthesis in the locale files so I've moved these to the locale string.
taslangraham
force-pushed
the
i10792-main
branch
2 times, most recently
from
b27797f to
e28dd00
Compare
taslangraham
force-pushed
the
i10792-main
branch
from
e28dd00 to
696128d
Compare
For #10792