Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1796

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Develop #1796

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab9765a
fix(TeslaFleetApiService): did return error on success status code
pkuehnel Jan 30, 2025
883a19f
Merge pull request #1795 from pkuehnel/fix/GetCarsFromAccount
pkuehnel Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TeslaSolarCharger/Server/Services/TeslaFleetApiService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1254,7 +1254,7 @@ public async Task<Fin<List<DtoTesla>>> GetAllCarsFromAccount()
return Fin<List<DtoTesla>>.Fail($"Could not deserialize response body");
}

if (teslaBackendResult.StatusCode is >= HttpStatusCode.OK and < HttpStatusCode.MultipleChoices)
if (!(teslaBackendResult.StatusCode is >= HttpStatusCode.OK and < HttpStatusCode.MultipleChoices))
{
logger.LogError("Error while getting all cars from account due to communication issue between Solar4Car Backend and Tesla: Underlaying Status code: {statusCode}; Underlaying Result: {jsonResult}", teslaBackendResult.StatusCode, teslaBackendResult.JsonResponse);
var excpetion = new HttpRequestException($"Requesting {requestUri} returned following statusCode: {teslaBackendResult.StatusCode} Underlaying result: {teslaBackendResult.JsonResponse}", null,
Expand Down
Loading