-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adh update tiny quickstart #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it (you want me to?), but the changes themselves LGTM>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the new iOS React Native Demo without any issues.
FWIW - in my experience it's easier to just create an entirely new app when upgrading several RN versions. They just copy the typescript code from the old app into the new one.
LGTM 🎉
So this was working for me, but later broke. It turns out I was hitting https://stackoverflow.com/questions/77783044/rctthirdpartyfabriccomponentsprovider-mm-build-input-file-cannot-be-found-react and ended up needing this fix facebook/react-native#42639 which meant I had to upgrade to .74 as well, which was a really difficult migration. Ugh. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕺
My project to upgrade the deps for the tiny quickstart took on a life of its own when I got to the react native section. As it turns out, the react native tiny quickstart for ios doesn't work with xcode 15.3 because of this issue:
facebook/react-native#43335
Anyway, like the naive fool I am, I decided to resolve this issue by upgrading to the version of React Native that contains the fix. "It's going from .71.14 to .73.6", I told myself, "how bad could it be?"
Anyway, 8 hours later, here we are!
Of note:
-Removed the clipboard package because it doesn't seem to be compatible with newer versions of RN (see Error to Deploy to Android RN 0.73.2 react-native-clipboard/clipboard#225) and I don't think we really needed it anyway
There's also a caveat: npm install will only work if I run it with the
--legacy-peer-deps
flag. I really don't like this for a sample app, but also I am using the dependencies recommended by the react native upgrade helper, so I'm not quite sure what to do about it.