Skip to content

Commit

Permalink
Bump org.seleniumhq.selenium:selenium-java from 4.12.1 to 4.17.0 in /…
Browse files Browse the repository at this point in the history
…Plan (#3434)

* Bump org.seleniumhq.selenium:selenium-java in /Plan

Bumps [org.seleniumhq.selenium:selenium-java](https://github.com/SeleniumHQ/selenium) from 4.12.1 to 4.17.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.17.0)

---
updated-dependencies:
- dependency-name: org.seleniumhq.selenium:selenium-java
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Use new headless setup method

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aurora Lahtela <[email protected]>
  • Loading branch information
dependabot[bot] and AuroraLS3 authored Jan 27, 2024
1 parent 89355d4 commit 512defb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Plan/common/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ dependencies {
testArtifacts project(":extensions:adventure")
testImplementation project(":extensions:adventure")
testImplementation "com.google.code.gson:gson:$gsonVersion"
testImplementation "org.seleniumhq.selenium:selenium-java:4.12.1"
testImplementation "org.seleniumhq.selenium:selenium-java:4.17.0"
testImplementation "org.testcontainers:testcontainers:$testContainersVersion"
testImplementation "org.testcontainers:junit-jupiter:$testContainersVersion"
testImplementation "org.testcontainers:nginx:$testContainersVersion"
Expand Down
4 changes: 2 additions & 2 deletions Plan/common/src/test/java/extension/SeleniumExtension.java
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public static void newTab(WebDriver driver) {

public static void waitForPageLoadForSeconds(int i, ChromeDriver driver) {
Awaitility.await("waitForPageLoadForSeconds")
.atMost(5, TimeUnit.SECONDS)
.atMost(i, TimeUnit.SECONDS)
.until(() -> "complete".equals(driver.executeScript("return document.readyState")));
}

Expand Down Expand Up @@ -92,7 +92,7 @@ private ChromeDriver getChromeWebDriver() {
// Using environment variable assumes linux
if (System.getenv(CIProperties.CHROME_DRIVER) != null) {
chromeOptions.setBinary("/usr/bin/google-chrome-stable");
chromeOptions.setHeadless(true);
chromeOptions.addArguments("--headless=new");
}

return new ChromeDriver(chromeOptions);
Expand Down

0 comments on commit 512defb

Please sign in to comment.