add try catch for patrol reward sheet #6733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene-doobu
requested review from
sonohoshi and
jonny-jeahyunchoi
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to enhance error handling in the
LoadPolicyInfomethod within thePatrolRewardmodel. The most important changes are:Error handling improvements:
nekoyume/Assets/_Scripts/UI/Model/PatrolReward.cs: Added a try-catch block to handle potentialInvalidOperationExceptionwhen no activated policy matches the criteria, logging an error message in such cases. [1] [2]