Custom MAIL environment variables being overwritten when Outgoing mail is disabled.

[sincilite]

We experienced a bug where the environment variables set in Platform.sh for the project's environment were being ignored when outgoing emails using P.sh's own SendGrid SMTP host.

The documentation says that disabling email through the project's settings UI sets the value of PLATFORM_SMTP_HOST to an empty string. Though testing on the instance suggests that the value is set to false.

Either way, the check previously was only looking at the existence of the config variable which meant project environment vars were always being overwritten with defaults set in the mapPlatformShMail function even when the values were not set.

I've switched the check to use empty() which allows the custom environment variables to be set correctly.

[budda]

Ah looks like this pull request might fix #21 !

[budda]

Any update on wether this fix works and will be made available in a new release?

[sincilite]

@budda We're running my fork in our Laravel based app running on Platform.sh. Mail settings are honoured and we're happy everything is working OK

[budda]

@budda We're running my fork in our Laravel based app running on Platform.sh. Mail settings are honoured and we're happy everything is working OK

@sincilite what's the correct syntax for composer to pull in this fork of the laravel-bridge package whilst waiting for a merge? I've tried loads and nothing seems to work, always ends with:-

  Problem 1
    - Root composer.json requires sincilite/laravel-bridge, it could not be found in any version, there may be a typo in the package name.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://getcomposer.org/doc/04-schema.md#minimum-stability> for more details.
 - It's a private package and you forgot to add a custom repository to find it```

[sincilite]

You'll need to set a repositories block in your composer.json file.

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/sincilite/laravel-bridge"
        }
    ],

and update your platformsh/laravel-bridge dependency to be platformsh/laravel-bridge: "dev-master"

You might need to set your minimum stability requirement to be "minimum-stability": "dev"

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/sincilite/laravel-bridge"
        }
    ],
    "require": {
        "platformsh/laravel-bridge": "dev-master",
    },
    "minimum-stability": "dev",
}

[budda]

Thanks @sincilite - the minor detail was:

and update your platformsh/laravel-bridge dependency to be platformsh/laravel-bridge: "dev-master"

i had changed the dependency to be sincilite/laravel-bridge: dev-master 🤦🏻

Also confirmed this PR fixes my problem with using AWS SES on PSH. Many thanks for sorting it @sincilite 👍🏻

[chadwcarlson]

Closes #21

Thank you @budda and @sincilite!

[budda]

@chadwcarlson are we getting a new tagged release of the package?

[chadwcarlson]

@budda - moved too fast. 🙇 https://github.com/platformsh/laravel-bridge/releases/tag/2.2.2