Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactors to account for large linkcheck reports #4390

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

gilzow
Copy link
Collaborator

@gilzow gilzow commented Feb 13, 2025

What's changed

Comments in issues are limited to 65536 characters. Refactors workflow to account for cases of large broken link check reports. In those cases it will save the link report as an artifact attached to the workflow run and then create an issue with a link back to the run.

Copy link
Contributor

@gregqualls gregqualls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Copy link

Your Platform.sh environment has successfully deployed. 🚀

See the site:

@gilzow gilzow merged commit 0b7b9dd into main Feb 13, 2025
26 of 30 checks passed
@gilzow gilzow deleted the fix-link-check branch February 13, 2025 23:07
@gilzow
Copy link
Collaborator Author

gilzow commented Feb 13, 2025

Tests were failing because of

  Validating 3 new domains
  E: Error validating domain fix-link-check-ejd76ni-ucq44jg6ofare.eu-5.platformsh.site: Couldn't complete challenge [HTTP01: The client lacks sufficient authorization]
  E: Error validating domain docs.upsun.com.fix-link-check-ejd76ni-ucq44jg6ofare.eu-5.platformsh.site: Couldn't complete challenge [HTTP01: The client lacks sufficient authorization]
  Unable to validate domains fix-link-check-ejd76ni-ucq44jg6ofare.eu-5.platformsh.site, docs.upsun.com.fix-link-check-ejd76ni-ucq44jg6ofare.eu-5.platformsh.site, will retry in the background.
  Provisioned new certificate for 1 domains
  (Next refresh will be at 2025-02-13 23:07:59.268075+00:00.)
  Certificates
  - certificate d850a6b: expiring on 2025-05-14 21:59:26+00:00, covering search.fix-link-check-ejd76ni-ucq44jg6ofare.eu-5.platformsh.site

W: Missing certificate for domain fix-link-check-ejd76ni-ucq44jg6ofare.eu-5.platformsh.site
W: Missing certificate for domain docs.upsun.com.fix-link-check-ejd76ni-ucq44jg6ofare.eu-5.platformsh.site

Which is unrelated to the changes implemented into the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants