fix: eslint v9 compatibility issues

[LucasHill]

Fixes #499

I verified all tests pass under eslint v9, but also maintained backward compatibility. Tests require updates that are not v8 compatible so I have another branch where I tested against v9. https://github.com/LucasHill/eslint-plugin-qunit/tree/test_fixes_for_eslint_v9

A future improvement would be to run this plugin against multiple eslint versions, as I can't include the test changes without committing to only testing on v9. If this is desired, I can bring those changes into this branch and the project will be upgraded to test against v9.

I do think it could be worth releasing this in a patch version as the changes are minimal, and intentionally backwards compatible. I know there are plans brewing for the v9 version of this library, but getting folks unblocked now would be awesome! This addon is particularly heavily used in the ember community so I'm trying to push all the eslint plugins in our ecosystem up to v9 compatibility.

Thank you!

[bmish]

I'm good with this fix and I know it's badly needed for ESLint v9 users. It's hard to test both ESLint versions at the same time, so we can just leave testing alone for now.

Can you also add some istanbul ignore comments so that these new lines don't require test coverage?

ERROR: Coverage for branches (98.51%) does not meet global threshold (100%)

[LucasHill]

@bmish thanks! pushed up those ignores and code coverage passed locally

[coveralls]

coverage: 100.0%. remained the same
when pulling 0e006c4 on LucasHill:fix_eslint_v9_compat_issues
into a74e161 on platinumazure:main.

[bmish]

@platinumazure could you release this? Having some trouble with the release command.

[bmish]

I have released the new 8.1.2 version to npm, can you folks test that?

@platinumazure there are a few more steps to finish up this release, described in:

• v8.1.2 #533

[bmish]

Release completed: https://github.com/platinumazure/eslint-plugin-qunit/releases/tag/v8.1.2