Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update english translations #20

Merged
merged 2 commits into from
Jul 17, 2024
Merged

update english translations #20

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a594b7d
update_english_translations
ruslandoga Jul 3, 2024
c68089f
ensure notes from prev PR are tested
ruslandoga Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mix_tasks/update_english_translations.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ defmodule Mix.Tasks.UpdateEnglishTranslations do
"KZ-75" => "Almaty City",
# https://en.wikipedia.org/wiki/ISO_3166-2:FI
"FI-01" => "Åland",
"FI-06" => "Kanta-Häme",
"FI-16" => "Päijät-Häme",
Copy link
Contributor Author

@ruslandoga ruslandoga Jul 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overriding it from Päijänne Tavastia to Päijät-Häme because GPT says it's the more common name in both English and Finnish https://chatgpt.com/share/1c672980-68ff-4f92-ba92-869825d61d47 and also because the Wikipedia article is titled that way https://en.wikipedia.org/wiki/Päijät-Häme. Similar for Kanta-Häme

# https://en.wikipedia.org/wiki/ISO_3166-2:FR
"FR-BL" => "Saint Barts",
"FR-NC" => "New Caledonia",
Expand Down
2 changes: 0 additions & 2 deletions priv/iso_3166-2.en-translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,15 +373,13 @@
"FI-02": "South Karelia",
"FI-03": "Southern Ostrobothnia",
"FI-04": "Southern Savonia",
"FI-06": "Tavastia Proper",
"FI-07": "Central Ostrobothnia",
"FI-08": "Central Finland",
"FI-10": "Lapland",
"FI-12": "Ostrobothnia",
"FI-13": "North Karelia",
"FI-14": "Northern Ostrobothnia",
"FI-15": "Northern Savonia",
"FI-16": "Päijänne Tavastia",
"FI-19": "Southwest Finland",
"FJ-08": "Nadroga-Navosa",
"FR-BFC": "Burgundy-Franche-Comté",
Expand Down
11 changes: 11 additions & 0 deletions test/location_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,17 @@ defmodule LocationTest do
# CZ
assert Location.get_subdivision("CZ-10").name == "Prague"
assert Location.get_subdivision("CZ-41").name == "Karlovy Vary"

# FI
assert Location.get_subdivision("FI-01").name == "Åland"
assert Location.get_subdivision("FI-06").name == "Kanta-Häme"
assert Location.get_subdivision("FI-16").name == "Päijät-Häme"

# CH
assert Location.get_subdivision("CH-BE").name == "Bern"

# LU
assert Location.get_subdivision("LU-CL").name == "Clervaux"
end
end

Expand Down
Loading