-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/implement pc.EVENT_MOUSEOUT and pc.EVENT_MOUSEENTER #4920
Open
kungfooman
wants to merge
12
commits into
playcanvas:main
Choose a base branch
from
kungfooman:eventMouseOut
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7c582ab
Add/implement pc.EVENT_MOUSEOUT
kungfooman d8adc32
Update src/platform/input/constants.js: making it clear that we aren'…
kungfooman 10d3655
Add EVENT_MOUSEENTER and rework to use Mouse#_target
kungfooman a2c8c28
Fix types
kungfooman 3faf2ba
Fix lint
kungfooman 6386212
Mouse#detach: fix mousein -> mouseenter ("opposite" of Mouse#attach)
kungfooman 3ba5cc3
Update src/platform/input/constants.js
kungfooman 2395405
@yaustar's suggestion with < 100 chars, GitHub is 500'ing
kungfooman 6875316
Update src/platform/input/constants.js
kungfooman f7dbb3b
JSDoc retexting
kungfooman d7233cb
Fix lint
kungfooman 5912854
Merge branch 'main' into eventMouseOut
mvaligursky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the same note, what values are coords.x/y on a mouse out event?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coords = mouse._getTargetCoords(event);
returns null and then the constructor just ends here:engine/src/platform/input/mouse-event.js
Lines 56 to 58 in 7c582ab
Resulting in the entire event being "uninitialized".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yaustar There are two cases:
mouseout
is fired and then its the normalx
/y
_getTargetCoords
returns null andx
/y
sticks to 0 (because_getTargetCoords
returns some proper values).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see 🤔 This seems fine to me