Migrate from bazel-distribution to rules_jvm_external for Maven distribution #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
brocollie08
reviewed
Jan 25, 2024
|
|
||
| # Load maven rules from git | ||
| def maven_repository( | ||
| remote = "https://github.com/sugarmanz/rules_jvm_external.git", |
There was a problem hiding this comment.
plan is to try to get your PR in rules_jvm_external merged, yea?
There was a problem hiding this comment.
Ideally, but IMO it's not really acceptable as-is. It requires an --experimental_google_legacy_api flag, which would require every consumer of the rules to enable that flag. I'm not sure what the path forward is, but will likely try to get some feedback from the team over there.
There was a problem hiding this comment.
Opened a PR for feedback:
bazel-contrib/rules_jvm_external#1049
brocollie08
approved these changes
Mar 15, 2024
sugarmanz
force-pushed
the
maven-export-distribution
branch
from
bd3cf58 to
8148d3a
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.