Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add generic stamp rule back in to stamp Podspec #46

Merged
merged 1 commit into from
Jun 4, 2024
Merged

add generic stamp rule back in to stamp Podspec #46

merged 1 commit into from
Jun 4, 2024

Conversation

hborawski
Copy link
Contributor

ported previous stamp rule for podspec stamping to use aspect rules for execution

@hborawski hborawski added the patch Increment the patch version when merged label Jun 4, 2024
@KetanReddy
Copy link
Member

Not sure if this is out of scope but should we update the js_pipeline macro to use this instead of the stamping during the tsup build so we don't have to rebuild the js to stamp it?

@hborawski hborawski mentioned this pull request Jun 4, 2024
Open
@hborawski
Copy link
Contributor Author

Added #47 to track consolidation

@hborawski hborawski merged commit ebb4360 into bazel-6 Jun 4, 2024
2 checks passed
@hborawski hborawski deleted the stamp-readd branch June 4, 2024 19:18
@intuit-svc
Copy link

🚀 PR was released in v1.0.0 🚀

@intuit-svc intuit-svc added the released This issue/pull request has been released. label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hborawski @KetanReddy @intuit-svc