-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config with default template 4eba7476 #3776
base: master
Are you sure you want to change the base?
Conversation
@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
"${sentances}. ${sentance}", | ||
mapping={"sentances": err, "sentance": error}, | ||
"${sentences}. ${sentence}", | ||
mapping={"sentences": err, "sentence": error}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erral codespell
was run, and this may mean that similar changes are needed in plone.app.locales
. Currently this PR is for CMFPlone master, which since today is only for Plone 6.1. But this PR should be back ported soon to new branch 6.0.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Some weeks ago I also modified manually the translations in such cases, so I would need to do it again when this is backported to 6.0.x.
Thanks for the heads up.
@gforcada I see problems with various templates, at least |
@mauritsvanrees all good 👍🏾 I applied I did not have time yesterday to look at the test failures, I did see them, but I was busy talking with you and others during the sprint 😅 |
This recreates PR #3775 which I had accidentally merged too soon.
BTW, some tests are failing, investigating now.