-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually disable explicit acquisition in Plone 6 #3872
base: 6.0.x
Are you sure you want to change the base?
Conversation
@gotcha thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gotcha Thanks for this fix. Would you be willing to add the test?
3823f8f
to
5d07a88
Compare
5d07a88
to
8672ddc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test would indeed be nice, but master does not have it either. Can be added later. I have marked this PR as ready for review.
@jenkins-plone-org please run jobs
Please do add a test. I was working with this setting recently to enable the check for a project, and I found the naming is quite confusing. The test can probably be something like this
|
Fix for #3871
This still needs tests in order to avoid regression again.