Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new filters to manipulate Python versions #70

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Implement new filters to manipulate Python versions #70

wants to merge 4 commits into from
+139 −11

Conversation

ericof
Copy link
Member

@ericof ericof commented Feb 27, 2025

Fixes #69

@ericof ericof added the 04 type: enhancement making existing stuff better label Feb 27, 2025
stevepiercy
stevepiercy requested changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refactored oldest to earliest, suggested a comment to explain PLONE_PYTHON, and fixed up some docstrings. Otherwise LGTM.

@ericof ericof requested a review from stevepiercy March 5, 2025 13:25
stevepiercy
stevepiercy approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

@stevepiercy
Copy link
Contributor

We've got some failing CI checks regarding "oldest" instead of "earliest", so I think there are some replacements that I missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy approved these changes

@davisagli davisagli Awaiting requested review from davisagli

Assignees
No one assigned
Labels
04 type: enhancement making existing stuff better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement new filters to manipulate Python versions
2 participants
@ericof @stevepiercy