-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vanilla or core volto demo site on volto.demo.plone.org #41
Conversation
…it ignored, so you can locally change storage for the backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started a review of the *.md files, but realized that it would take less time to push commits to this branch instead. I'll do that later today. Meanwhile, here are a couple of suggestions to keep it moving forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cleaned up the READMEs
@stevepiercy Thanks. I’ve set the pr to draft as the next step is to test the GHA workflows, but these only run correctly on the main branch. So for that I need to reserve some availabe time to ‘push through’ any errors I encounter, otherwise the demo’s no longer reset/refresh. But it’s not rocket science. The naming was the most challening: we can reuse the backend contIner image for the existing demo.plone.org but the frontend for a vanilla volto needs its own build. I want to avoid naming it ‘core’ volto. Vanilla Volto is too jummy and ice cream, so I opted for frontend-volto. We can clarify the setup in the README. |
Co-authored-by: Steve Piercy <[email protected]>
This makes sense to me, and is consistent with the hierarchical naming pattern There is also an effort to get consistent names for make targets. See plone/cookiecutter-volto#14 |
No description provided.