Require Python 3.8+, configure with plone/meta #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…higher. Remove all buildout configs. They all seem really old and unmaintained, though there could still be value in them.
lib is in the updated .gitignore file, and in Plone we expect the code to be in src, not in lib. No other changes in this commit.
Only handle zcml (which is one file). When handling html and/or xml, we get various test failures like these: * `TypeError: a bytes-like object is required, not 'str'` * `lxml.etree.XMLSyntaxError: Entity 'nbsp' not defined, line 4, column 59` * `lxml.etree.XMLSyntaxError: Entity 'Acirc' not defined, line 11, column 20` * `AssertionError: False is not true`
It does not take the 'wsgi' extra into account.
|
@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
The Jenkins 5.2 jobs are mentioned above. I have now switched coredev 5.2 to use newly created branch 1.x. @jenkins-plone-org please run jobs |
gforcada
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pours the
plone/metasauce over this package.Some notes:
lxml5. If I or someone else wants to fix this, it helps if we are not trying to test Python 2.7 still.libtosrc.zpretty, because causes various test failures, and mostly touches test files. Could be picked up later.tox -e dependenciescomplains about missing requirementsrepoze.xmliterandwebob, but these are in thewsgiextras_require. I disabled the GitHub action for this.