Fix test in combination with lxml 5+ due to namespace changes. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this example, an xpath `/html/body/include` cannot be found because lxml 5 sees it as `/html/body/esi:include`, but this cannot easily be used as an xpath. Fixes #87
|
@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
mauritsvanrees
added a commit
to plone/buildout.coredev
that referenced
this pull request
Apr 23, 2024
* We are using verion 4 until now. * Version 5 gives a test error in Diazo. That is fixed in plone/diazo#88. * In lxml 5.2.0 and higher, `lxml.html.clean` was factored out into an extra package, and not pulled in by default. Fixed by plone/Products.PortalTransforms#62. * This coredev PR for 6.0 checks out branches for those two packages, it updates lxml to latest, and it adds a pin for the new `lxml_html_cleaner` package. Once green, this PR should not be merged, because we do not want to use those PR branches. The right order would be something like this: * Merge the Diazo PR, it is fine for lxml 4 and 5. * Add `lxml-html-clean = 0.1.1` to the versions in 6.0 and 6.1. * Merge the PortalTransforms PR, which then pulls in the new package without giving an error for a missing version pin. * Update the lxml version to latest 5.2.1.
jensens
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this example, an xpath
/html/body/includecannot be found because lxml 5 sees it as/html/body/esi:include, but this cannot easily be used as an xpath.Fixes #87