-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add chapter on relations from mastering plone (slighty updated) #1290
Conversation
✅ Deploy Preview for 6-dev-docs-plone-org ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From time to time I think it would be good to stop defining target sets of a relation field in its widget. Cause this is a constraint of its data structure (Plone: schema) and not a matter of the display (Plone: widget).
I will review this in the next day or two. I'm working on other docs at the moment. Please do not merge yet. Thank you! |
General comment, with details coming in a full review later. Documentation should be the authoritative source, not Training. We should pull content from the Training, and insert and adapt it in Documentation. If that is too much work for now, then I would be OK with leaving the I also think that this would give some newbies an opportunity to contribute by repurposing Training material into Documentation. Or so I hope. @pbauer what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my first round of review.
I did not start on the mammoth backend/relations.md
, but I will start nibbling on that pachyderm one bite at a time over the next day or so.
Yes. The chapters on relations, and the dexterity-reference can be moved to the docs without mayor changes. I'll remove them from the training and link to the docs once these are merged.
Yes
You can always hope but I doubt it. |
Issues created: |
Added meta data and TODOs in 443a010. |
I'm going to continue editing and pushing commits to this tomorrow. The commits I pushed so far are just meta and technical stuff that we should include in docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent work. To save review cycles, I made lots of nit-picky commits to clean up English and MyST syntax and grammar.
I have a few additional questions. Please see the comments and suggestions.
Thank you!
… seems to be not needed)
Add TODOs. Add periods.
No description provided.