Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the docs black #568

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Make the docs black #568

merged 1 commit into from
Mar 5, 2025

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented Mar 4, 2025 •
edited by github-actions bot
Loading

This cherry-picks some changes from #562 that are not really related to that PR.

📚 Documentation preview 📚: https://ploneapi--568.org.readthedocs.build/

@ale-rt ale-rt requested a review from stevepiercy March 4, 2025 09:14
@mister-roboto
Copy link

@ale-rt thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

stevepiercy
stevepiercy approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

@stevepiercy
Copy link
Contributor

Just needs a change log entry, then good to merge.

@ale-rt
Copy link
Member Author

ale-rt commented Mar 4, 2025

I would not even add that, but if you think it is required I will

@stevepiercy
Copy link
Contributor

A note about blacking code examples in the docs sets an example to follow. I'm fine either way.

@ale-rt
Copy link
Member Author

ale-rt commented Mar 4, 2025

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit 6ac61e4 into main Mar 5, 2025
17 of 19 checks passed
@davisagli davisagli deleted the ale/black/docs branch March 5, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

@stevepiercy stevepiercy stevepiercy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ale-rt @mister-roboto @stevepiercy @davisagli