Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intro suggesting deprication of Archetypes #302

Merged
merged 3 commits into from
Nov 5, 2019
Merged

Update intro suggesting deprication of Archetypes #302

merged 3 commits into from
Nov 5, 2019

Conversation

flipmcf
Copy link
Contributor

@flipmcf flipmcf commented Oct 30, 2019

First stab at new intro paragraph. I'm not in love with it.

Maybe we should remove the suggestions that "Dexterity is an alternative to Archetypes" and update our history to suggest that Plone embraced Dexerity as of version 5 and deprecated it at 5.2

First stab at new intro paragraph.  I'm not in love with it.
@mister-roboto
Copy link

@flipmcf you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

@mister-roboto
Copy link

@flipmcf thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@flipmcf
Copy link
Contributor Author

flipmcf commented Oct 30, 2019

Agreement signed.

@flipmcf
Copy link
Contributor Author

flipmcf commented Oct 30, 2019

Fixes #301

Improves:

  • Suggests Dexterity types as preferred over Archetypes

Changes proposed in this pull request:

  • Rewrite final paragraphs of introduction to Dexterity Developer Manual

@flipmcf flipmcf closed this Oct 31, 2019
@flipmcf flipmcf reopened this Oct 31, 2019
@mister-roboto
Copy link

@flipmcf thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

docs/intro.rst Outdated
All that said, Archetypes is still an older and more mature framework. Dexterity is a viable alternative to Archetypes in many projects, but if you are happy with Archetypes, you should not immediately rush to rewrite your types to use Dexterity.

There are also some things that Dexterity does not yet support, or, more commonly, services that Plone ships with that currently assume all content objects are built using Archetypes. The current list of "gaps" can be found in the Dexterity issue tracker. You should take a look at this before deciding whether Dexterity will work for you. If in doubt, don't hesitate to write to the Dexterity mailing list and ask for advice.
As of version 5 of Plone, Dexterity is the preferred way of creating content types. Additionally, Archetypes was removed from Plone core in 5.2. It can still be added to Plone to support Archetypes-based add-ons, but it will not function when running Plone using Python 3. If you are considering upgrading to Plone 5 and Python 3, you are reading the right documentation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content is fine, but please follow the doc style for all new edits; here: One sentence per line.
https://docs.plone.org/develop/styleguide/documentation.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flipmcf flipmcf requested a review from jensens November 1, 2019 15:58
Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I totally missed that you edited the CHANGES.rst. For various reasons we switched to using towncrier now for almost all Plone repositories. Please add a file to the /news/ folder named 302.bugfix and add the changelog line there.

@flipmcf
Copy link
Contributor Author

flipmcf commented Nov 4, 2019

Force push reverted CHANGES.rst back.

@jensens jensens merged commit b08b01f into plone:master Nov 5, 2019
@flipmcf flipmcf deleted the #301 branch November 5, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants