Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #57

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

@mister-roboto
Copy link

@pre-commit-ci[bot] thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@gforcada
Copy link
Member

We have a circular dependency here:

p.a.layout depends on p.a.viewletmanager

but p.a.viewletmanager needs plone.app.layout.globals.interfaces.IViewView from p.a.layout 🙃

Should we move that interface to plone.base? 🤔

updates:
- [github.com/pycqa/isort: 5.13.2 → 6.0.1](PyCQA/isort@5.13.2...6.0.1)
- [github.com/psf/black: 24.10.0 → 25.1.0](psf/black@24.10.0...25.1.0)
- [github.com/PyCQA/flake8: 7.1.1 → 7.1.2](PyCQA/flake8@7.1.1...7.1.2)
- [github.com/codespell-project/codespell: v2.3.0 → v2.4.1](codespell-project/codespell@v2.3.0...v2.4.1)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 59d334d to e7d124d Compare March 3, 2025 18:37
@gforcada gforcada force-pushed the pre-commit-ci-update-config branch 3 times, most recently from b9383e7 to 760750a Compare March 3, 2025 23:33
@gforcada gforcada force-pushed the pre-commit-ci-update-config branch from 760750a to 44bb3e4 Compare March 3, 2025 23:35
@gforcada gforcada merged commit f1ec55f into master Mar 3, 2025
14 of 20 checks passed
@gforcada gforcada deleted the pre-commit-ci-update-config branch March 3, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants