-
-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get multilingual settings from backend #5506
Conversation
✅ Deploy Preview for volto canceled.
|
89499b3
to
01dc782
Compare
@erral the server has to know in advance this setting too. If not, all SSR requests will be "not multilingual". A golden rule is that the (nowadays static) config should be the same in server and in the client. Sometimes, one tend to forget that they are "detached" physically. Knowing this setting in advance, is part of what I've come to call "bootstrap config info" service that should be retrieved from the server as first thing (there are several others, like is working copy enabled, or this site accept registrations), before everything else happens, first in SSR, passed then to the client. We've postponed it a lot of times because pulling this off won't be easy in a performant way. |
@erral I took a look again to this PR and now I saw the I am wondering if we could have a full-backend implementation for this use case, so we can even spare the /cc @davisagli |
❌ Deploy Preview for plone-components failed. Why did it fail? →
|
This reverts commit 0edd013.
See #6818 for the new version |
To be tested with plone/plone.restapi#1738