Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get multilingual settings from backend #5506

Closed
wants to merge 4 commits into from
Closed

Conversation

erral
Copy link
Member

@erral erral commented Dec 7, 2023

To be tested with plone/plone.restapi#1738

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 5ee7475
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6574908e7c98e300087000d9

@erral erral force-pushed the erral-languages-play branch from 89499b3 to 01dc782 Compare December 9, 2023 16:02
@sneridagh
Copy link
Member

@erral the server has to know in advance this setting too. If not, all SSR requests will be "not multilingual". A golden rule is that the (nowadays static) config should be the same in server and in the client. Sometimes, one tend to forget that they are "detached" physically.

Knowing this setting in advance, is part of what I've come to call "bootstrap config info" service that should be retrieved from the server as first thing (there are several others, like is working copy enabled, or this site accept registrations), before everything else happens, first in SSR, passed then to the client. We've postponed it a lot of times because pulling this off won't be easy in a performant way.

@sneridagh
Copy link
Member

@erral I took a look again to this PR and now I saw the getMultilingualInstalledAsyncPropExtender solution. Could be that I missed that from your initial implementation, or you added it later? I think this will solve my initial concerns.

I am wondering if we could have a full-backend implementation for this use case, so we can even spare the getMultilingualInstalledAsyncPropExtender solution (eg. included in the @site endpoint). I wanted also to hold off this one also in case we started using @plone/client in Volto, but since this is most likely never happen, I am wondering if it's now ok to push again for this. What do you think?

/cc @davisagli

Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for plone-components failed. Why did it fail? →

Name Link
🔨 Latest commit 41ad9de
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/67c6d9de5cbd6600080df4ea

This reverts commit 0edd013.
@erral
Copy link
Member Author

erral commented Mar 7, 2025

See #6818 for the new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants