Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HtmlSlateWidget to proper identify the field to screen readers #6772

Open
wants to merge 10 commits into
base: 17.x.x
Choose a base branch
from

Conversation

Wagner3UB
Copy link
Contributor

@Wagner3UB Wagner3UB commented Feb 21, 2025

Correction applied to ensure proper screen reader identification of text fields created through the HtmlSlateWidget.

PR volto 18 #6803

@Wagner3UB Wagner3UB self-assigned this Feb 21, 2025
@Wagner3UB Wagner3UB changed the title Slate FormFieldWrapper to proper identify the field to screen readers HtmlSlateWidget to proper identify the field to screen readers Feb 21, 2025
@giuliaghisini
Copy link
Contributor

@Wagner3UB some tests are failing, probably because you have to update snapshots..
Could you also make a pr for main too?

@giuliaghisini
Copy link
Contributor

@Wagner3UB there are some test still failing.. check them

@Wagner3UB
Copy link
Contributor Author

@davisagli Can you help me here? I don’t think the problem is related to my changes. Cypress is returning an error in the file field.js when it tries to create a new text block from the ‘most used’ ones, but the text block isn’t there. In other words, the text block is not one of the most used ones.

cy.get('.blocks-chooser .mostUsed .button.testBlock').click();

Screenshot:
Screenshot 2025-03-05 alle 12 10 26

@nileshgulia1
Copy link
Member

@Wagner3UB I had something like this when running tests locally and found out that I was not running with the correct fixture. Maybe try running with coresandbox fixtures specifically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants