Token Widget Label #6786
Merged
Token Widget Label #6786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevepiercy
requested changes
Feb 26, 2025
Co-authored-by: Steve Piercy <[email protected]>
I'd really prefer to review and merge changes first for the master branch, then backport them to older branches. I don't want a situation where we merge something for an old branch and then forget to port it forward. |
Closed
|
@davisagli This should be correct now. I’ll reply here with what I said on the other related PR: the problem was that this file was already fixed in Volto 18, so the modification I made there was not necessary. I will close the v18 PR and leave only the v17 one open. I will replicate the modification made here to v17, to be compliant. |
davisagli
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added aria-label to CreatableSelect inside the TokenWidget to better accessibility.
PR for Volto 18: #6804