Add validator for default_language in language control panel
#6811
+111
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
stevepiercy
requested changes
Mar 5, 2025
stevepiercy
approved these changes
Mar 5, 2025
davisagli
reviewed
Mar 6, 2025
| config.registerUtility({ | ||
| name: 'default_language', | ||
| type: 'validator', | ||
| dependencies: { format: 'default_language' }, |
There was a problem hiding this comment.
Can you use fieldName: 'default_language' so plone/plone.i18n#73 isn't needed?
There was a problem hiding this comment.
We don't have this feature (yet). Do you really think it's the way to go? For me, the problem is the lack of expressivity in the definition of the fields in the backend source, which is not Volto to blame. And it's not only here. It's all over the place in the backend fields definitions.
Specially on control panels. So the field fix in plone/plone.i18n#73 should not only be the hint for the client side validation, but also having a server one where the validation of the default_language field is tied to the available_languages one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the use case that you can save a new default language without adding it to the list of available languages.
Now it complains, on blur and on save.
Probably, it would need a server side validator too.
Depends on plone/plone.i18n#73 but not requires it.
Also fixes a section of the docs that was incorrect.
📚 Documentation preview 📚: https://volto--6811.org.readthedocs.build/