Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #6805 fixed (with additional bug fixed) #6814

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ManojaD2004
Copy link

Fixed open issue #6805

Addition bugs that I faced:

  1. When the cursor is at the beginning of the slate text editor and pressed the 'backspace' key, it would append the content of the previous slate text block.
  2. When we were at the end of the slate text editor and pressed the 'delete' key, it would append the content of the next slate text block.

Note:

We need to make sure the slate text editor is removed and focused on the previous slate text block only when it has no content in the current slate text editor.

Bug Fix:

  • To handle this weird behavior, I created a function and checked these two edge cases. This pull request has fixed the main bug mentioned in the open issue, and also fixed the additional bugs mentioned above.

Test the bug:

  1. Add a new page.
  2. Add some three slate blocks with some text in them.
  3. Be at the second slate block, make sure your cursor is at the beginning of the second slate block, and press 'backspace'. (Notice the weird behaviour.)
  4. Again, be at the second slate block, make sure your cursor is at the end of the second slate block, and press 'delete'.

Bug screenshot:
Screenshot 2025-03-07 193148
Screenshot 2025-03-07 193215

Copy link

boring-cyborg bot commented Mar 7, 2025

Caution

The Volto Team has suspended its review of new pull requests from first-time contributors until the release of Plone 7, which is preliminarily scheduled for the second quarter of 2026.
Read details.

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, read
Plone's Code of Conduct,
Contributing to Plone,
First-time contributors, and
Contributing to Volto,
as this will greatly help the review process.

Welcome to the Plone community! 🎉

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 77fad5d
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/67cc1b3c8ef3390008c63bcd

@ManojaD2004 ManojaD2004 force-pushed the bug-fix-6805 branch 2 times, most recently from 7aada67 to 4465c0f Compare March 7, 2025 20:22
@ManojaD2004
Copy link
Author

Hey @sneridagh, @stevepiercy, I have solved an open issue #6805 and also, along with it, solved additional bugs mentioned above.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant