[#132]: Proposed Fix - "Plot show Method Not Working on Windows 10" (…

…#133) * Changes to `show` method for Windows * `CHANGELOG.md` PR credits updated
plotly · Jul 9, 2023 · ac975d2 · ac975d2
1 parent 8903ff0
commit ac975d2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,7 +5,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
 
 ## [0.8.4] - 2023-01-xx
 ### Fixed
-- [[#129](https://github.com/igiagkiozis/plotly/pull/129)] Fix issue for plots not showing in browser in Windows. Thanks to [@juanespj](https://github.com/juanespj) for the PR.
+- [[#129](https://github.com/igiagkiozis/plotly/pull/129)] Fix issue for plots not showing in browser in Windows. Thanks to [@juanespj](https://github.com/juanespj) and [@M-NK-Y](https://github.com/M-NK-Y) for the PRs.
 
 ## [0.8.3] - 2022-11-04
 ### Fixed

diff --git a/plotly/src/plot.rs b/plotly/src/plot.rs
@@ -471,9 +471,8 @@ impl Plot {
     fn show_with_default_app(temp_path: &str) {
         use std::process::Command;
         Command::new("cmd")
-            .arg("/C")
-            .arg(format!("start {}", temp_path))
-            .output()
+            .args(&["/C", "start", &format!(r#"{}"#, temp_path)])
+            .spawn()
             .expect(DEFAULT_HTML_APP_NOT_FOUND);
     }
 }