Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust colors to fit 5.7. color palette #404

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Adjust colors to fit 5.7. color palette #404

merged 2 commits into from
Jul 8, 2021

Conversation

krafit
Copy link
Member

@krafit krafit commented Jul 8, 2021

see #378

@krafit krafit added this to the 2.10 milestone Jul 8, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Zodiac1978
Copy link
Member

Zodiac1978 commented Jul 8, 2021 •
edited
Loading

Do you think this is a visible change? Or too subtle?
Do you have before/after screenshots?

Otherwise LGTM!

@krafit
Copy link
Member Author

krafit commented Jul 8, 2021

@Zodiac1978 It's a slight change. You can see the difference if you see old and new side by side, but I don't think it's noticeable otherwise.

Bildschirmfoto 2021-07-08 um 10 32 53

before (left), after (right)

@Zodiac1978
Copy link
Member

Zodiac1978 commented Jul 8, 2021 •
edited
Loading

This looks fine and complete.

The only thing we could think about is "merging" some colors, like Grey20 and Grey30 and just go with Grey30 for example.

Or aim a higher goal and try to go even more with the new higher contrast colors. Statify seems to have this already:

Bildschirmfoto 2021-07-08 um 10 54 02

Bildschirmfoto 2021-07-08 um 10 54 23

Edit:
See this PR: pluginkollektiv/statify@19de105

@Zodiac1978 Zodiac1978 linked an issue Jul 8, 2021 that may be closed by this pull request
Adjust colors with WP 5.7 color palette #378
Closed
@Zodiac1978
Copy link
Member

UI changes are handled in #406

Zodiac1978
Zodiac1978 approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@Zodiac1978 Zodiac1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zodiac1978 Zodiac1978 merged commit 7f2a60d into master Jul 8, 2021
@pfefferle pfefferle deleted the 378-color-adjustment branch July 10, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zodiac1978 Zodiac1978 Zodiac1978 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

Adjust colors with WP 5.7 color palette
2 participants
@krafit @Zodiac1978