-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy third-party libs instead of using Composer autoloader (#256) #260
Conversation
The autoloader mechanism is quite heavy for a single dependency and requires composer and vendor dir to be part of the final product. We yet have generated/minified resources in our project, so this is the minimalistic approach to copy the CrawlerDetect lib, too and extend the custom autoloader mechanism.
6e37dc9
to
c6a0c0b
Compare
The only thing missing here would be to add the CrawlerDetect file(s) to the |
The autoloader mechanism is quite heavy for a single dependency and requires composer and vendor dir to be part of the final product. We yet have generated/minified resources in our project, so this is the minimalistic approach to copy the CrawlerDetect lib, too and extend the custom autoloader mechanism.
c6a0c0b
to
ede3443
Compare
The autoloader mechanism is quite heavy for a single dependency and requires composer and vendor dir to be part of the final product. We yet have generated/minified resources in our project, so this is the minimalistic approach to copy the CrawlerDetect lib, too and extend the custom autoloader mechanism.
ede3443
to
f72e0e9
Compare
You're right, seems the line got lost at some point. Re-added the missing directory to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The autoloader mechanism is quite heavy for a single dependency and requires composer and vendor dir to be part of the final product. We yet have generated/minified resources in our project, so this is the minimalistic approach to copy the CrawlerDetect lib, too and extend the custom autoloader mechanism.
f72e0e9
to
75b2198
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
fixes #256
The autoloader mechanism is quite heavy for a single dependency and requires composer and vendor dir to be part of the final product.
We yet have generated/minified resources in our project, so this is the minimalistic approach to copy the CrawlerDetect lib, too and extend the custom autoloader mechanism.
This is not a pretty solution, but the project is not really Composer compatible. (no PSR-4 namespaces, requirement for minified files that are generated from dev-dependencies, etc.).
This way we ca postpone the decision to heavily rework the project structures while having a runnable artifact again.