do not return NULL, if database is empty

[stklcode]

Null causes trouble during further processing, i.e. PHP warnings in the API processing and later on problems building the dashboard widget in Javascript, because all methods expect the array to have all keys.

Move the caching (transient) directive into the conditional, so we still do not cache empty results and so not return NULL anymore.

---

This part will produce a couple of warnings, if get_stats() returns null:

statify/inc/class-statify-api.php

Lines 127 to 129 in 0ec5f69

	$stats = Statify_Dashboard::get_stats( $refresh );
	$visits = $stats['visits'];

And this part will fail:

statify/js/dashboard.js

Lines 161 to 166 in 0ec5f69

	function renderTopList(table, data) {
	// Get pre-existing rows.
	const rows = table.querySelectorAll('tr');
	// Update or append rows.
	data.forEach((r, idx) => {

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication