move invisible tooltip to the top left corner to prevent layout shift #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stklcode
force-pushed
the
fix/tooltip-offset
branch
from
8f79ca0
to
d49342c
Compare
stklcode
force-pushed
the
fix/tooltip-offset
branch
from
d49342c
to
6ce6f5e
Compare
florianbrinkmann
approved these changes
Apr 5, 2024
The tooltip is placed at the bottom of the body which makes the page slightly longer, even though the user can't see the content. This might result in a layout shift when the tooltip is displayed for the first time and the scrollbar disappears. Move the invisible tooltip element to the top-left corner fixes this issue. We use left/top CSS properties, because these two will be dynamically overwritten on mouse events anyway.
stklcode
force-pushed
the
fix/tooltip-offset
branch
from
6ce6f5e
to
e127700
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
The tooltip is placed at the bottom of the body which makes the page slightly longer, even though the user can't see the content. This might result in a layout shift when the tooltip is displayed for the first time and the scrollbar disappears.
To Reproduce
Expected behavior
Tooltip is displayed without additional layout shift.
Solution
Move the invisible tooltip element to the top-left corner fixes this issue. We use left/top CSS properties, because these two will be dynamically overwritten on mouse events anyway.