Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[I18n] Add JavaScript i18n, typo and brand names #280

Merged
merged 8 commits into from
Apr 12, 2024

Conversation

pedro-mendonca
Copy link
Contributor

This PR includes the following:

  • Add JavaScript i18n to proper deal with JavaScript strings, including plurals, variables, etc
  • Fix statify Statify brand name
  • Typo

@stklcode
Copy link
Contributor

stklcode commented Nov 25, 2023

Thanks Pedro!

I think we should add wp-i18n to the JS dependencies explicitly. On the dashboard it should be present anyway, so it works without, but relying on that is probably not best practice, is it?`

wp_register_script(
'statify_chart_js',
plugins_url( 'js/dashboard.min.js', STATIFY_FILE ),
array( 'wp-api-fetch', 'chartist_tooltip_js' ),
self::$_plugin_version,
true
);

ping #253 for another WP 5.0+ argument

@pluginkollektiv pluginkollektiv deleted a comment from sonarcloud bot Mar 29, 2024
Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

@pedro-mendonca
Copy link
Contributor Author

@stklcode I've added the wp-i18n core script to the dependencies as you've requested.
Thanks for the review :)

@stklcode stklcode added this to the 2.0.0 milestone Apr 12, 2024
@stklcode stklcode self-requested a review April 12, 2024 18:05
Copy link
Contributor

@stklcode stklcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @pedro-mendonca for taking care of that!

@stklcode stklcode merged commit 11cd722 into pluginkollektiv:develop Apr 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants