Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflow to run wp plugin checks #292

Closed
wants to merge 1 commit into from
Closed

Conversation

stklcode
Copy link
Contributor

@stklcode stklcode commented Sep 21, 2024

Add a new workflow to run the plugin-check-action when pushing or merging to stable.

We build the plugin first and re-use the .distignore file to generate the final plugin package. Otherwise we should run into several issues with files. This list is also used for deployment, so the results should be as representative as it gets.


Run on current develop branch shows one error:

Error: The Stable Tag in your readme file does not match the version in your main plugin file. Your Stable Tag is meant to be the stable version of your plugin, not of WordPress. For your plugin to be properly downloaded from WordPress.org, those values need to be the same. If they’re out of sync, your users won’t get the right version of your code.

That's correct and intentional on the develop branch. Hence we should start running the full set of checks only before merging to stable.

and a few warnings

Warning: One or more tags were ignored. Please limit your plugin to 5 tags.

(now fixed, see #293)

Warning: Use of a direct database call is discouraged.
Warning: Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().

(already known from PHPCS)

@stklcode stklcode force-pushed the ci/plugin-check branch 3 times, most recently from 5241b9c to 70a8fff Compare September 22, 2024 08:46
Copy link

sonarcloud bot commented Sep 22, 2024

@stklcode
Copy link
Contributor Author

Forgot about this PR, the check workflow is now active (f0c3a40)

@stklcode stklcode closed this Nov 11, 2024
@stklcode stklcode deleted the ci/plugin-check branch November 11, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant