-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix user default entity injection #433
base: main
Are you sure you want to change the base?
Conversation
waiting from customer feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good
waiting from customer feedback |
Validated by the customer |
Hostely, I do not know this plugin, nor the way it works... But as far as I understand, you've replace Since there is no unit tests, I really do not know if it has an impact... But I guess we should be sure before changing that kind of things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you get the customer to validate this new version?
All good for him |
a more precise comment on the difficulty of going through the GLPI core (restriction of entities etc ...) |
Co-authored-by: Romain B. <[email protected]>
Checklist before requesting a review
Please delete options that are not relevant.
Description
Fix default entity insertion for a user