-
Notifications
You must be signed in to change notification settings - Fork 76
docker: remove hub package from Fedora Rawhide #977
docker: remove hub package from Fedora Rawhide #977
Conversation
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
==========================================
+ Coverage 94.05% 94.12% +0.06%
==========================================
Files 48 48
Lines 4712 4712
==========================================
+ Hits 4432 4435 +3
+ Misses 280 277 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
e702cc4
to
a8baf8b
Compare
4d8d37f
to
2c3c027
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
2c3c027
to
b4b77e6
Compare
e9de62e
to
a2f84e3
Compare
it's required by run-doc-update.sh which is not executed on this OS and apparently this package is not available in repository.
a2f84e3
to
3b43a26
Compare
I've updated this PR with a quick check for hub command. We may face in some near future missing hub package, so it's good to have this check. Ref. #1013 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, 2 of 4 files at r5.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)
utils/docker/run-doc-update.sh, line 90 at r5 (raw file):
echo "Make sure hub command is available:" hub --version
Maybe we should interrupt execution of script when we doesn't have a hub?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KFilipek)
utils/docker/run-doc-update.sh, line 90 at r5 (raw file):
Previously, KFilipek (Krzysztof Filipek) wrote…
Maybe we should interrupt execution of script when we doesn't have a hub?
thanks to that line, we do that. It's guaranteed on top of the file:
set -e
(-e Exit immediately if a command exits with a non-zero status.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)
utils/docker/run-doc-update.sh, line 90 at r5 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
thanks to that line, we do that. It's guaranteed on top of the file:
set -e
(-e Exit immediately if a command exits with a non-zero status.)
Great, thanks, I don't know it
it's required by run-doc-update.sh which is not executed on this OS
and apparently this package is not available in repository.
This change is