Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

docker: remove hub package from Fedora Rawhide #977

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

lukaszstolarczuk
Copy link
Member

@lukaszstolarczuk lukaszstolarczuk commented Nov 13, 2020

it's required by run-doc-update.sh which is not executed on this OS
and apparently this package is not available in repository.


This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #977 (3b43a26) into master (dde1e8a) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #977      +/-   ##
==========================================
+ Coverage   94.05%   94.12%   +0.06%     
==========================================
  Files          48       48              
  Lines        4712     4712              
==========================================
+ Hits         4432     4435       +3     
+ Misses        280      277       -3     
Flag Coverage Δ
tests_clang_debug_cpp17 93.59% <ø> (+0.04%) ⬆️
tests_gcc_debug 91.72% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/transaction.hpp 82.56% <0.00%> (+0.91%) ⬆️
include/libpmemobj++/condition_variable.hpp 78.57% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dde1e8a...3b43a26. Read the comment docs.

@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft November 16, 2020 10:09
Copy link
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

it's required by run-doc-update.sh which is not executed on this OS
and apparently this package is not available in repository.
@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review February 5, 2021 13:07
@lukaszstolarczuk
Copy link
Member Author

I've updated this PR with a quick check for hub command. We may face in some near future missing hub package, so it's good to have this check.

Ref. #1013

Copy link
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, 2 of 4 files at r5.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)


utils/docker/run-doc-update.sh, line 90 at r5 (raw file):

echo "Make sure hub command is available:"
hub --version

Maybe we should interrupt execution of script when we doesn't have a hub?

Copy link
Member Author

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KFilipek)


utils/docker/run-doc-update.sh, line 90 at r5 (raw file):

Previously, KFilipek (Krzysztof Filipek) wrote…

Maybe we should interrupt execution of script when we doesn't have a hub?

thanks to that line, we do that. It's guaranteed on top of the file:
set -e
(-e Exit immediately if a command exits with a non-zero status.)

Copy link
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)


utils/docker/run-doc-update.sh, line 90 at r5 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

thanks to that line, we do that. It's guaranteed on top of the file:
set -e
(-e Exit immediately if a command exits with a non-zero status.)

Great, thanks, I don't know it

@lukaszstolarczuk lukaszstolarczuk merged commit 21576bf into pmem:master Feb 19, 2021
@lukaszstolarczuk lukaszstolarczuk deleted the fix-fedora-rawhide branch February 19, 2021 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants