Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Skip log matching when EXPECT_SPURIOUS_SYSCALLS=ON #32

Merged
merged 1 commit into from
Jul 3, 2017

Conversation

GBuella
Copy link
Contributor

@GBuella GBuella commented Jul 3, 2017

It is too hard to predict what is going to end up in the logs
with ASAN, gcov, etc...

The logs are still checked while doing tests without EXPECT_SPURIOUS_SYSCALLS, so this should not be a problem. I gave up on matching logs after this build: https://travis-ci.org/GBuella/syscall_intercept/jobs/249368556

Ref: #7


This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   56.93%   56.93%           
=======================================
  Files          18       18           
  Lines        1486     1486           
  Branches      413      413           
=======================================
  Hits          846      846           
  Misses        440      440           
  Partials      200      200

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed18c0b...08c9165. Read the comment docs.

It is too hard to predict what is going to end up in the logs
with ASAN, gcov, etc...
@krzycz
Copy link
Contributor

krzycz commented Jul 3, 2017

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@sarahjelinek
Copy link
Contributor

:lgtm:


Reviewed 2 of 2 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@sarahjelinek sarahjelinek merged commit 6c19526 into pmem:master Jul 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants