charts/metabase add securityContext hooks #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow users to specify thier own securityContext. This adds hooks
jhunterc15
changed the title
jhunterc15
changed the title
jhunterc15
changed the title
|
@jhunterc15 For cleaner values.yaml, I would like to ask you to move Thanks for contributing ! |
Renamed metabaseSecurityContext to securityContext and moved cloudsqlSecurityContext to database.googleCloudSQL.securityContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow users to specify their own securityContext.
I created separate hooks for metabase and cloudsql so that they can be different if the user wants them to be. Let me know if you like these changes and I can add them to the documentation as a part of this PR.