-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
charts/metabase add sidecars for main deployment #90
charts/metabase add sidecars for main deployment #90
Conversation
LGTM |
hi @pmint93, since we are urgent to use this feature of your helm chart, please help us review it, thank you very much :D |
This is the value so that you can better review them
|
@letronghoangminh What's the purpose of sidecar ? Can you share more about your use cases ? |
hi @pmint93 , thank you for replying, specifically about my use case, we are installing Metabase on a EKS Fargate cluster, which make it required to use a Datadog Agent container as a sidecar for exporting metrics and logs to Datadog. That's why we need this feature to be implemented. Thank you very much |
This addition allows to add the sidecars block to the main deployment, it allows bare customization so users can custom the sidecars based on Kubernetes manifest syntax
The Chart version has already been added as well as the documentation for variables