Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Continuous integration and start lesson plan #5

Merged
merged 28 commits into from
Jan 17, 2024
Merged

Add Continuous integration and start lesson plan #5

merged 28 commits into from
Jan 17, 2024

Conversation

richelbilderbeek
Copy link
Collaborator

Hi @pmitev,

With this Pull Request I add two extra continuous integrations scripts:

  • spell checking: works great, I've fixed the existing spelling errors too
  • link checking: works great. There are 4 broken links, I put those in mlc_config.json as exceptions, as I cannot fix those for you

Also I added a (start of a ) lesson plan for Monday and a picture.

If you want to keep most, I hope you will accept this PR and delete the stuff you do not like :-)

Cheers, Richel

@richelbilderbeek
Copy link
Collaborator Author

@pmitev I would enjoy an 'Accept' or 'Reject' or 'Request changes'. What will it be?

@richelbilderbeek
Copy link
Collaborator Author

richelbilderbeek commented Jan 17, 2024

To sum up a discussion on Slack:

  • Problem: CI is useful, but it should never get in the way
  • Answer: It will not let it get in the way either, I will only make it point out mistakes

Merging (when the build passes cleanly, of course) :-)

@richelbilderbeek richelbilderbeek merged commit 49d6310 into pmitev:master Jan 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant