[Not For Merge Yet] BREAKING: unmount async dependencies

[dai-shi]

split from #2920

I thought it's nice to fix memory leak test, but it might not worth the breaking behavior.

We don't plan to merge this for now. We would like to collect more feedback on it, especially the failing test case not only in this repo, but also in the ecosystem. So, one of the purposes of this PR is to run jotai-ecosystem-ci to learn the effect of this breaking behavioral change.

---

Proposed Change In Behavior

Atom dependencies of async atoms are unmounted and remounted each time the async atom recomputes if they are accessed only after a delay. This will cause any atom.onMount and unmount functions to fire each time.

Example

const countAtom = atom(0)
countAtom.onMount = () => {
  console.log('countAtom mounted')
  return () => {
    console.log('countAtom unmounted')
  }
}

const asyncAtom = atom(async (get) => {
  await Promise.resolve()
  get(countAtom)
})

const store = createStore()

const unsub = store.sub(asyncAtom, () => {}) // mounts asyncAtom
await Promise.resolve()

console.log('set countAtom to 1')
store.set(countAtom, 1)
await Promise.resolve()

console.log('set countAtom to 2')
store.set(countAtom, 2)
await Promise.resolve()

unsub()

Current

set countAtom to 1
set countAtom to 2

New

countAtom mounted
set countAtom to 1
countAtom unmounted
countAtom mounted
set countAtom to 2
countAtom unmounted
countAtom mounted
countAtom unmounted

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
jotai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 16, 2025 2:08pm

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[pkg-pr-new]

Open in Stackblitz

More templates

• hacker_news
• hello
• mega-form
• starter
• text_length
• todos
• todos_with_atomFamily

npm i https://pkg.pr.new/jotai@2940

commit: d6a015d

[github-actions]

Size Change: -142 B (-0.15%)

Total Size: 91.7 kB

Filename	Size	Change
./dist/esm/vanilla.mjs	4.15 kB	-26 B (-0.62%)
./dist/system/vanilla.development.js	4.25 kB	-25 B (-0.59%)
./dist/system/vanilla.production.js	2.15 kB	-18 B (-0.83%)
./dist/umd/vanilla.development.js	5.64 kB	-29 B (-0.51%)
./dist/umd/vanilla.production.js	2.76 kB	-15 B (-0.54%)
./dist/vanilla.js	5.53 kB	-29 B (-0.52%)

ℹ️ View Unchanged

Filename	Size
./dist/babel/plugin-debug-label.js	932 B
./dist/babel/plugin-react-refresh.js	1.14 kB
./dist/babel/preset.js	1.41 kB
./dist/esm/babel/plugin-debug-label.mjs	1 kB
./dist/esm/babel/plugin-react-refresh.mjs	1.19 kB
./dist/esm/babel/preset.mjs	1.49 kB
./dist/esm/index.mjs	62 B
./dist/esm/react.mjs	1.4 kB
./dist/esm/react/utils.mjs	746 B
./dist/esm/utils.mjs	67 B
./dist/esm/vanilla/utils.mjs	5.04 kB
./dist/index.js	242 B
./dist/react.js	1.44 kB
./dist/react/utils.js	1.39 kB
./dist/system/babel/plugin-debug-label.development.js	1.1 kB
./dist/system/babel/plugin-debug-label.production.js	775 B
./dist/system/babel/plugin-react-refresh.development.js	1.29 kB
./dist/system/babel/plugin-react-refresh.production.js	928 B
./dist/system/babel/preset.development.js	1.59 kB
./dist/system/babel/preset.production.js	1.14 kB
./dist/system/index.development.js	252 B
./dist/system/index.production.js	183 B
./dist/system/react.development.js	1.56 kB
./dist/system/react.production.js	864 B
./dist/system/react/utils.development.js	860 B
./dist/system/react/utils.production.js	462 B
./dist/system/utils.development.js	257 B
./dist/system/utils.production.js	187 B
./dist/system/vanilla/utils.development.js	5.25 kB
./dist/system/vanilla/utils.production.js	3.14 kB
./dist/umd/babel/plugin-debug-label.development.js	1.08 kB
./dist/umd/babel/plugin-debug-label.production.js	852 B
./dist/umd/babel/plugin-react-refresh.development.js	1.27 kB
./dist/umd/babel/plugin-react-refresh.production.js	1 kB
./dist/umd/babel/preset.development.js	1.54 kB
./dist/umd/babel/preset.production.js	1.22 kB
./dist/umd/index.development.js	383 B
./dist/umd/index.production.js	328 B
./dist/umd/react.development.js	1.57 kB
./dist/umd/react.production.js	936 B
./dist/umd/react/utils.development.js	1.53 kB
./dist/umd/react/utils.production.js	1.01 kB
./dist/umd/utils.development.js	399 B
./dist/umd/utils.production.js	342 B
./dist/umd/vanilla/utils.development.js	6.24 kB
./dist/umd/vanilla/utils.production.js	3.78 kB
./dist/utils.js	247 B
./dist/vanilla/utils.js	6.1 kB

_{compressed-size-action}

[github-actions]

Preview in LiveCodes

Latest commit: d6a015d
Last updated: Jan 16, 2025 2:08pm (UTC)

Playground	Link
React demo	https://livecodes.io?x=id/2DKLSYQZE

---

See documentations for usage instructions.