preliminary work for projection changes #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
would loop for the incorrect amount of times when copying over contents that don't match
- name the change color function and properly label the render_lighting member
fix typo when calculating the y position, function would multiply output->vectors.left.j by inverse_pos.x rather than inverse_pos.y previously.
- add VALIDATE_REAL_ENABLED preprocessor constant - add macros: assert_valid_real and valid_real_matrix4x3 - add functions: valid_real_point3d, valid_real_vector3d_axes3, valid_real_matrix4x3, negate_vector3d, and scale_vector4d - adjust parameter names in cross_product3d
nukeulater
reviewed
Jan 9, 2025
nukeulater
reviewed
Jan 9, 2025
- remove return value from matrix4x3_inverse - remove unneeded if statement from c_rasterizer_constant_4f_cache::test_cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes and additions to prepare for projection work