ImportError Fixed: Use jax.config.update and remove import .__version #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Nico and contributors of tornadox,
Thanks for sharing your work!
When importing your package, I found two issues that cause import error: (1) Importing
jax.config
is deprecated in newer Jax (2)._version
file is missing. This PR provides a minimal change that required to import with latest Jax version. Please let me know your thoughts!Issue
The changes of this PR include:
Importing
jax.config
Since JAX 0.4.20, the following way to import
config
is deprecated. This can cause error for newer Jax version, and the current version fails to import._version
not foundAnother issue is the
._version
is missing in the package. I simply removed this part to make the package imported without error.Suggestion
As described in this PR, I did two thing in
__init__.py
jax.config
._version
Tested System
Best,
Steven Chiu