Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json schema static site generation #16

Closed
wants to merge 6 commits into from

Conversation

KapilDuwadi
Copy link
Collaborator

No description provided.

@KapilDuwadi
Copy link
Collaborator Author

@charliepnnl This PR is just for collecting your reviews. Will not resolve conflict for now.

@charliepnnl
Copy link
Contributor

This is looking great!

Here are some possible improvements:

  • As I mentioned in a chat message, the field detail "can not be null" can be removed for all feilds.
  • The high-level list of resolved json schema files could be alphabetized. That will better align with our other json schema documentation.
  • I'm not sure that the Table of Contents on the right of each page adds very much and could be eliminated.
  • For the heading "IRA Rebate API JSON Schema Static Site" at the top of the list of schemas on the left:
    • It might be more useful to call this something like: "Resolved JSON Schemas" or "API Payload Schemas".
    • Can the styling be changed to make this heading stand out a bit more. Currently it looks like the first item in the list rather than a heading.

@KapilDuwadi KapilDuwadi deleted the json-schema-static-site-generation branch February 20, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants